Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this work on 1.10? #50

Closed
vanjavk opened this issue Oct 1, 2016 · 4 comments
Closed

Does this work on 1.10? #50

vanjavk opened this issue Oct 1, 2016 · 4 comments
Labels

Comments

@vanjavk
Copy link

vanjavk commented Oct 1, 2016

I have spigot 1.10 running and when I try to connect it just says logged in and nothing happens: http://i.imgur.com/CYf4D1U.png

@Bottersnike
Copy link

#49 might be of use

@joodicator joodicator added the bug label Oct 1, 2016
@joodicator
Copy link
Collaborator

Thank you for the report. This was a bug in pyCraft caused by missing protocol version data for 1.10.1 and 1.10.2, and an infinite loop in the automatic protocol version negotiator.

It should be fixed now in 7ab7381.

@vanjavk
Copy link
Author

vanjavk commented Oct 1, 2016

Hello, I first tried downloading protocolsupport as mentioned in #49 however it didn't help, then I downloaded your new version and it didn't work, only after I deleted protocolsupport it started working.
So for anyone else in future, protocolsupport might prevent you from connecting.

Also, is it possible to make it work with protocolsupport, because I think most servers are using it?
And would this even work on servers with hubs? (I can't connect to the server I want using this (saicopvp.com -> Witch))

@joodicator
Copy link
Collaborator

For compatibility with the ProtocolSupport plugin for Spigot, it may be necessary to specify the initial protocol version as one (presumably the highest) that ProtocolSupport supports using the initial_version argument of the minecraft.networking.connection.Connection constructor. Otherwise, pyCraft attempts to connect using its highest supported version (snapshot 16w39c as of this post) and receives a disconnect message from ProtocolSupport that it does not understand.

The start.py example that comes with pyCraft doesn't support setting the protocol version as a command-line argument, but it could be easily modified to do so. My own mcchat2 is an example of a more complicated client using pyCraft that supports this functionality.

Alternatively, pyCraft could be modified to support ProtocolSupport automatically, but since this is not a vanilla issue, I'm not sure it belongs on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants