Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activate commented tests after implementing validation methods #30

Closed
0pdd opened this issue Apr 10, 2019 · 7 comments
Closed

activate commented tests after implementing validation methods #30

0pdd opened this issue Apr 10, 2019 · 7 comments
Labels
pdd puzzle

Comments

@0pdd
Copy link
Collaborator

0pdd commented Apr 10, 2019

The puzzle 31-1d05e01b from #31 has to be resolved:

Attendance/attendance/test/userdata_test.dart

Line 12 in a2a27b7

// @todo #31 activate commented tests after implementing validation methods

The puzzle was created by @Bahaaib on 10-Apr-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Apr 10, 2019
@Bahaaib
UPDATED: commented out unused tests
a2a27b7
This was referenced Apr 10, 2019
Closed
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Apr 10, 2019

@0pdd the puzzle #32 is still not solved.

@0crat
Copy link
Collaborator

0crat commented Apr 10, 2019

@ammaratef45/z please, pay attention to this issue

@0crat 0crat removed their assignment Apr 10, 2019
@0crat 0crat added the scope label Apr 10, 2019
@0crat
Copy link
Collaborator

0crat commented Apr 10, 2019

Job #30 is now in scope, role is DEV

@0pdd 0pdd mentioned this issue Apr 11, 2019
Merged
@Bahaaib Bahaaib mentioned this issue Apr 13, 2019
Merged
Bahaaib added a commit to Bahaaib/Attendance that referenced this issue Apr 13, 2019
@Bahaaib
REMOVED: Puzzle ammaratef45#30
b6a094b
@0pdd 0pdd closed this as completed Apr 13, 2019
@0pdd
Copy link
Collaborator Author

0pdd commented Apr 13, 2019

The puzzle 31-1d05e01b has disappeared from the source code, that's why I closed this issue.

@0pdd
Copy link
Collaborator Author

0pdd commented Apr 13, 2019

@0pdd the only puzzle #32 is solved here.

@0crat
Copy link
Collaborator

0crat commented Apr 13, 2019

Job gh:ammaratef45/attendance#30 is not assigned, can't get performer

@0crat 0crat removed the scope label Apr 13, 2019
@0crat
Copy link
Collaborator

0crat commented Apr 13, 2019

The job #30 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pdd puzzle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0crat @0pdd