Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to Bloc design pattern #88

Open
ammaratef45 opened this issue May 5, 2019 · 6 comments
Open

Refactor to Bloc design pattern #88

ammaratef45 opened this issue May 5, 2019 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@ammaratef45
Copy link
Owner

Use the library https://github.com/felangel/bloc to refactor to Bloc design pattern.
all PRs should be to Bloc branch, later we may merge the Bloc branch to master if things went well.
@ammaratef45 ammaratef45 added the help wanted Extra attention is needed label May 5, 2019
@ammaratef45 ammaratef45 mentioned this issue May 5, 2019
Open
@felangel
Copy link

felangel commented May 5, 2019

@ammaratef45 have you started yet? If not I can try to help you get started in a few hours.

@ammaratef45
Copy link
Owner Author

@felangel Not yet
Just created the brach Bloc

@felangel
Copy link

felangel commented May 5, 2019

Okay awesome! I'll try to open a PR where I refactor a single section (login for example) sometime later today 👍

@ammaratef45
Copy link
Owner Author

@felangel Great 👍

@felangel
Copy link

felangel commented May 5, 2019

@ammaratef45 opened #89

@ammaratef45
Copy link
Owner Author

@felangel It 's merged, Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@felangel @ammaratef45