Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font issues #94

Closed
ammaratef45 opened this issue May 16, 2019 · 24 comments
Closed

Font issues #94

ammaratef45 opened this issue May 16, 2019 · 24 comments
Labels
bug Something isn't working

Comments

@ammaratef45
Copy link
Owner

A puzzle for #93
We should use a custom text widget that has the default font size and family in the style and reuses it everywhere.

The task is to create a widget for the custom text and let it have a default font family and size then replace all Text widgets with it

@ammaratef45 ammaratef45 added the bug Something isn't working label May 16, 2019
@0crat 0crat added the scope label May 16, 2019
@0crat
Copy link
Collaborator

0crat commented May 16, 2019

Job #94 is now in scope, role is DEV

@ammaratef45
Copy link
Owner Author

@amorenew what do you think about this? can you accomplish it?

@amorenew
Copy link
Contributor

@ammaratef45 Yes I can, assign it to my account.
what is your expectation for the delivery date?

@0crat
Copy link
Collaborator

0crat commented May 16, 2019

Bug was reported, see §29: +15 point(s) just awarded to @ammaratef45/z

@ammaratef45
Copy link
Owner Author

@0crat assign @amorenew

@0crat
Copy link
Collaborator

0crat commented May 16, 2019

@0crat assign @amorenew (here)

@ammaratef45 The job #94 assigned to @amorenew/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; @amorenew/z is not a member of this project yet, but they can request to join, as §1 explains; there will be no monetary reward for this job

@ammaratef45
Copy link
Owner Author

@ammaratef45 Yes I can, assign it to my account.
what is your expectation for the delivery date?

Sooner is better, you manage your schedule
Let me know if there are any barriers, I will facilitate whatever you want.

@0crat
Copy link
Collaborator

0crat commented May 16, 2019

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @ammaratef45/z

@amorenew
Copy link
Contributor

@ammaratef45 Once the build #95 issue is fixed I can start this task.

@ammaratef45
Copy link
Owner Author

@amorenew FYI, you can ask zerocrat to hold the issue
for example say:
@0crat wait for resolution of #95

@0crat
Copy link
Collaborator

0crat commented May 17, 2019

Are you speaking to me or about me here; you must always start your message with my name if you want to address it to me, see §1

@amorenew
Copy link
Contributor

amorenew commented May 18, 2019

@ammaratef45 I made a widget but after R&D I found a better solution by using the theme I can make a default text style with font family and font size for Text widget only
check this >> https://api.flutter.dev/flutter/material/TextTheme-class.html
body1 is for Text widgets

theme: ThemeData(
        textTheme: TextTheme(body1: TextStyle(backgroundColor: Colors.red))
      )

So should I use Widget or define the default values in TextTheme?
Screenshot_1558146880

@ammaratef45
Copy link
Owner Author

@amorenew I prefer the solution you've found, let's go with it 😄

@amorenew
Copy link
Contributor

@0crat wait for resolution of #97

@0crat 0crat added the waiting label May 18, 2019
@0crat
Copy link
Collaborator

0crat commented May 18, 2019

@0crat wait for resolution of #97 (here)

@amorenew The impediment for #94 was registered successfully by @amorenew/z

@ammaratef45
Copy link
Owner Author

@amorenew please don't wait for #97, It will not stop your work from being merged (tests will fail locally only)

@amorenew
Copy link
Contributor

@0crat continue

@0crat 0crat removed the waiting label May 18, 2019
@0crat
Copy link
Collaborator

0crat commented May 18, 2019

@0crat continue (here)

@amorenew @amorenew/z continued working on job #94

@ammaratef45
Copy link
Owner Author

@amorenew Good work.

@0crat
Copy link
Collaborator

0crat commented May 19, 2019

@sereshqua/z please review this job completed by @amorenew/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label May 19, 2019
@0crat
Copy link
Collaborator

0crat commented May 19, 2019

The job #94 is now out of scope

@sereshqua
Copy link
Collaborator

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented May 19, 2019

Order was finished, quality is "good": +35 point(s) just awarded to @amorenew/z

@0crat
Copy link
Collaborator

0crat commented May 19, 2019

Quality review completed: +4 point(s) just awarded to @sereshqua/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants