Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#31 created reusable dialogs #33

Merged
merged 1 commit into from Mar 18, 2019
Merged

#31 created reusable dialogs #33

merged 1 commit into from Mar 18, 2019

Conversation

ammaratef45
Copy link
Owner

PR for #31

  • Created Dialogs module.
  • Leaved a todo to continue replacement.

@ammaratef45
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Mar 18, 2019

@rultor merge

@ammaratef45 OK, I'll try to merge now. You can check the progress of the merge here

@0crat 0crat added the scope label Mar 18, 2019
@0crat
Copy link
Collaborator

0crat commented Mar 18, 2019

Job #33 is now in scope, role is REV

@rultor rultor merged commit 1d27fd8 into master Mar 18, 2019
@rultor
Copy link
Collaborator

rultor commented Mar 18, 2019

@rultor merge

@ammaratef45 Done! FYI, the full log is here (took me 14min)

@ammaratef45 ammaratef45 deleted the dialog_module branch March 18, 2019 07:09
@0crat
Copy link
Collaborator

0crat commented Mar 18, 2019

Job gh:ammaratef45/zold-flutter-client#33 is not assigned, can't get performer

@0crat 0crat removed the scope label Mar 18, 2019
@0crat
Copy link
Collaborator

0crat commented Mar 18, 2019

The job #33 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ammaratef45 @rultor @0crat @0pdd