Skip to content

Commit

Permalink
cifs: Support fscache rewrite
Browse files Browse the repository at this point in the history
  • Loading branch information
dhowells committed Jan 14, 2022
1 parent d775438 commit 76e2a61
Show file tree
Hide file tree
Showing 9 changed files with 179 additions and 513 deletions.
1 change: 1 addition & 0 deletions fs/cifs/Kconfig
Expand Up @@ -2,6 +2,7 @@
config CIFS
tristate "SMB3 and CIFS support (advanced network filesystem)"
depends on INET
select NETFS_SUPPORT
select NLS
select CRYPTO
select CRYPTO_MD5
Expand Down
2 changes: 2 additions & 0 deletions fs/cifs/cifsglob.h
Expand Up @@ -1321,6 +1321,7 @@ struct cifs_aio_ctx {

/* asynchronous read support */
struct cifs_readdata {
struct netfs_read_subrequest *subreq;
struct kref refcount;
struct list_head list;
struct completion done;
Expand All @@ -1339,6 +1340,7 @@ struct cifs_readdata {
int (*copy_into_pages)(struct TCP_Server_Info *server,
struct cifs_readdata *rdata,
struct iov_iter *iter);
struct iov_iter iter;
struct kvec iov[2];
struct TCP_Server_Info *server;
#ifdef CONFIG_CIFS_SMB_DIRECT
Expand Down
3 changes: 3 additions & 0 deletions fs/cifs/cifsproto.h
Expand Up @@ -237,6 +237,9 @@ extern int cifs_read_page_from_socket(struct TCP_Server_Info *server,
unsigned int page_offset,
unsigned int to_read);
extern int cifs_setup_cifs_sb(struct cifs_sb_info *cifs_sb);
extern int cifs_read_iter_from_socket(struct TCP_Server_Info *server,
struct iov_iter *iter,
unsigned int to_read);
extern int cifs_match_super(struct super_block *, void *);
extern int cifs_mount(struct cifs_sb_info *cifs_sb, struct smb3_fs_context *ctx);
extern void cifs_umount(struct cifs_sb_info *);
Expand Down
16 changes: 12 additions & 4 deletions fs/cifs/cifssmb.c
Expand Up @@ -23,6 +23,7 @@
#include <linux/swap.h>
#include <linux/task_io_accounting_ops.h>
#include <linux/uaccess.h>
#include <linux/netfs.h>
#include "cifspdu.h"
#include "cifsglob.h"
#include "cifsacl.h"
Expand Down Expand Up @@ -1332,11 +1333,11 @@ int
cifs_discard_remaining_data(struct TCP_Server_Info *server)
{
unsigned int rfclen = server->pdu_size;
int remaining = rfclen + server->vals->header_preamble_size -
size_t remaining = rfclen + server->vals->header_preamble_size -
server->total_read;

while (remaining > 0) {
int length;
ssize_t length;

length = cifs_discard_from_socket(server,
min_t(size_t, remaining,
Expand Down Expand Up @@ -1551,7 +1552,15 @@ cifs_readv_callback(struct mid_q_entry *mid)
rdata->result = -EIO;
}

queue_work(cifsiod_wq, &rdata->work);
if (rdata->subreq) {
netfs_subreq_terminated(rdata->subreq,
(rdata->result == 0 || rdata->result == -EAGAIN) ?
rdata->got_bytes : rdata->result,
false);
kref_put(&rdata->refcount, cifs_readdata_release);
} else {
queue_work(cifsiod_wq, &rdata->work);
}
DeleteMidQEntry(mid);
add_credits(server, &credits, 0);
}
Expand Down Expand Up @@ -1996,7 +2005,6 @@ cifs_writev_complete(struct work_struct *work)
else if (wdata->result < 0)
SetPageError(page);
end_page_writeback(page);
cifs_readpage_to_fscache(inode, page);
put_page(page);
}
if (wdata->result != -EAGAIN)
Expand Down
16 changes: 16 additions & 0 deletions fs/cifs/connect.c
Expand Up @@ -656,6 +656,22 @@ cifs_read_page_from_socket(struct TCP_Server_Info *server, struct page *page,
return cifs_readv_from_socket(server, &smb_msg);
}

int
cifs_read_iter_from_socket(struct TCP_Server_Info *server, struct iov_iter *iter,
unsigned int to_read)
{
struct msghdr smb_msg;
int ret;

smb_msg.msg_iter = *iter;
if (smb_msg.msg_iter.count > to_read)
smb_msg.msg_iter.count = to_read;
ret = cifs_readv_from_socket(server, &smb_msg);
if (ret > 0)
iov_iter_advance(iter, ret);
return ret;
}

static bool
is_smb_response(struct TCP_Server_Info *server, unsigned char type)
{
Expand Down

0 comments on commit 76e2a61

Please sign in to comment.