"NA" BGP Prefix causes error

[dacamp]

Sorry I didn't catch this in issue #10, but the BGP Prefix can also be "NA", which causes an error on the client side.

The "AS Name" field is also NA, so that may cause an issue too.

Raw Value: NA      | 193.32.71.189    | NA                  | UA | ripencc  | 2018-04-26 | NA
2018/10/08 14:17:41 There was an error: invalid CIDR address: NA

[dacamp]

This was the fix I have in place, but that will set Response.Range to nil, which may possibly break client code.

// Read range
if string(tokens[2]) != "NA" {
        if _, re.Range, err = net.ParseCIDR(string(tokens[2])); err != nil {
        return
        }
}

[ammario]

Hmm.. How about setting it to 0.0.0.0/32?

[dacamp]

Since it's unknown I think 0.0.0.0/0 makes more sense

[ammario]

I think it would be safer for a consumer to assume that the ISP contains no IP ranges than every IP.

[dacamp]

0.0.0.0/0 is known as the default route, but I can see where you're coming from.

How about something like using the IP address as a /32? For the above example 193.32.71.189/32?

All of the solutions feel hokey, so I don't have a good answer.

[ammario]

The IP/32 sounds good to me. And yes, every solution sucks :/

…

On Mon, Oct 8, 2018, 5:05 PM David Campbell ***@***.***> wrote: 0.0.0.0/0 is known as the default route, but I can see where you're coming from. How about something like using the IP address as a /32? For the above example 193.32.71.189/32? All of the solutions feel hokey, so I don't have a good answer. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHEpUDYJj1YlNIxhVv9Vnvbq2_lglKOfks5ui8wngaJpZM4XNsoP> .

[ammario]

Fixed in #15