extended matcher to allow for new definition of num-dot-decimal where… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… values like '.23' are now allowed
|
This fix can be tested against the file https://www.sec.gov/Archives/edgar/data/746515/000095017023039847/0000950170-23-039847-xbrl.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation:
https://www.xbrl.org/Specification/inlineXBRL-transformationRegistry/CR-2019-04-19/inlineXBRL-transformationRegistry-CR-2019-04-19.html#sec-ixt-20
numbers can also start simply with the decimal part without integer part.
I.e. ".23"
The current code throws an exception in this case, as it can't match numbers without the integer part.
As the rule states "The integer part is now optional if the dot and fractional part are present", I proposed in my change to add an alternative pattern to the matcher