Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned and Ordered data sets #6

Closed
wants to merge 1 commit into from
Closed

Conversation

bvanev
Copy link

@bvanev bvanev commented Jun 29, 2018

cleaned UTF-* encoded data to prevent the need for additional processing, resulting in clean display of text when rendered in all browsers other than Chrome on MacOS and Windows

Data ordered by 1.'Company' 2.'diameter_in' in projectiles.json and projectiles.csv

Data order by 'diameter_in' in {company}.json and {company}.csv files

…ing, resulting in clean display of text when rendered in all browsers other than Chrome on MacOS and Windows

Data ordered by 1.'Company' 2.'diameter_in' in projectiles.json and projectiles.csv

Data order by 'diameter_in' in {company}.json and {company}.csv files
@erichiggins
Copy link
Contributor

Thanks for the PR, @bvanev !!

Unicode characters

Since the display issue was an HTML bug, is it still necessary to remove the unicode characters? Perhaps the files could be duplicated with ascii-only copies for those who require them (e.g. projectiles_ascii.csv and sierra_ascii.csv)?

Data ordering

As mentioned in the README, it's quite impractical to order and structure the data in a way that works for every use-case. That said, here's what I'd suggest:

projectiles.*

Order by

  1. type
  2. company
  3. diameter
  4. weight
  5. sku (if needed)

<company>.*

Order by

  1. type
  2. diameter
  3. weight
  4. sku (if needed)

@bvanev
Copy link
Author

bvanev commented Jun 30, 2018

Unicode Characters

I will add the characters back into the data sets. I agree that there is no need to remove them.

Data Ordering

I will also order per your suggestion. I agree that it is difficult to meet every use case. Anything other than this can be managed by the consumer of the data sets.

Once these items are done, I will submit a new pull request.

@erichiggins
Copy link
Contributor

Hey @bvanev , just resurfacing this in your inbox. Are you planning on making the changes to this PR or creating a new one? Thanks again for the suggestions and contribution!

@erichiggins
Copy link
Contributor

@bvanev Ping 👋

This was referenced Aug 21, 2018
@erichiggins
Copy link
Contributor

Closing for now since it appears to be abandoned and the ordering issue has been fixed in #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants