Re-enable core/cover block #259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckground image covers the whole block
…ckground image covers the whole block
jaymcp
force-pushed
the
feat/enable-core-cover-block
branch
from
3ea118c
to
d4cb7e8
Compare
|
Rebased |
jaymcp
requested changes
Jul 16, 2024
There was a problem hiding this comment.
I'm not sure this is needed. Is there a specific reason for this change?
There was a problem hiding this comment.
I was having issues with the image not displaying correctly, either displaying too small or too big so the image cannot be viewed properly. This was to force the image to the correct size
There was a problem hiding this comment.
Examples
Before: http://bigbite.im/i/VS0qVe
After: http://bigbite.im/i/99omfT
…ite/humanity-theme into feat/enable-core-cover-block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #262
Re-enables the core/cover block and adds some styles to ensure the background image covers the whole block
Steps to test:
Example: http://bigbite.im/i/BbPGtZ