Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logic of install_docker.sh #420

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Improve logic of install_docker.sh #420

merged 1 commit into from
Nov 17, 2023

Conversation

lunardunno
Copy link
Collaborator

@lunardunno lunardunno commented Nov 5, 2023 •
edited by tiaga
Loading

  • check packages update only when it's required
  • avoid dnf/yum update for RHEL-based systems

@lunardunno lunardunno assigned lunardunno and unassigned lunardunno Nov 7, 2023
@lunardunno lunardunno marked this pull request as draft November 8, 2023 03:12
@lunardunno lunardunno marked this pull request as ready for review November 13, 2023 04:43
@tiaga
Improve logic of install_docker.sh
362a82f 
- check packages update only when it's required
- avoid `dnf/yum update` for RHEL-based systems
@tiaga tiaga changed the title Adaptation to different os Improve logic of install_docker.sh Nov 14, 2023
@tiaga tiaga requested a review from pokamest November 14, 2023 09:58
@pokamest pokamest merged commit ef0530e into dev Nov 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@useribs useribs useribs left review comments

@tiaga tiaga tiaga approved these changes

@pokamest pokamest pokamest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lunardunno @tiaga @useribs @pokamest