Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve install_docker.sh #431

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Improve install_docker.sh #431

merged 1 commit into from
Dec 14, 2023

Conversation

lunardunno
Copy link
Collaborator

@lunardunno lunardunno commented Nov 21, 2023 •
edited by tiaga
Loading

  • add delays before and after Docker activation
  • cancel installation if sudo wasn't found

@lunardunno lunardunno changed the title Unification of the script for different OS Unification of install_docker.sh for different OS Nov 21, 2023
@lunardunno lunardunno changed the title Unification of install_docker.sh for different OS Minimization and unification of install_docker.sh for different OS Nov 22, 2023
@lunardunno lunardunno marked this pull request as draft November 22, 2023 19:51
@lunardunno lunardunno marked this pull request as ready for review November 23, 2023 04:56
@lunardunno lunardunno marked this pull request as draft November 23, 2023 16:57
@lunardunno lunardunno changed the title Minimization and unification of install_docker.sh for different OS Unification of install_docker.sh for different OS Nov 24, 2023
@lunardunno lunardunno marked this pull request as ready for review November 24, 2023 14:55
@lunardunno lunardunno changed the title Unification of install_docker.sh for different OS Unification of install_docker.sh for different OS, and Ubuntu 22 bugfix Nov 24, 2023
@lunardunno lunardunno marked this pull request as draft November 25, 2023 01:50
@lunardunno lunardunno changed the title Unification of install_docker.sh for different OS, and Ubuntu 22 bugfix Unification of install_docker.sh for different OS. Nov 25, 2023
@lunardunno lunardunno changed the title Unification of install_docker.sh for different OS. minimization and unification of install_docker.sh for different OS. Nov 25, 2023
@lunardunno lunardunno marked this pull request as ready for review November 25, 2023 10:04
@lunardunno lunardunno marked this pull request as draft November 27, 2023 09:23
@tiaga
Improve install_docker.sh
4fd0852 
- add delays before and after Docker activation
- cancel installation if `sudo` wasn't found
@tiaga tiaga force-pushed the re_second_adaptation_to_diff_os branch from f0e1112 to 4fd0852 Compare November 27, 2023 14:48
@lunardunno lunardunno marked this pull request as ready for review November 28, 2023 09:08
@tiaga tiaga changed the title minimization and unification of install_docker.sh for different OS. Improve install_docker.sh Dec 4, 2023
@pokamest pokamest merged commit be799da into dev Dec 14, 2023
8 checks passed
@pokamest pokamest deleted the re_second_adaptation_to_diff_os branch December 14, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiaga tiaga tiaga approved these changes

@pokamest pokamest Awaiting requested review from pokamest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lunardunno @tiaga @pokamest