-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android refactoring #452
Android refactoring #452
Conversation
Move to gradle kotlin DSL Use gradle version catalog All android build parameters are set via cmake files Use gradle abi split to build APKs Improve local development in the android project folder
BuildConfig class is now only created in the utils module
Vpn reconnects when the default network is changed
Remove the path filter, as the content path may not contain a filename. Disable import when viewing files. Config can be imported from: - shared file - shared text - vpn:// link
…ireguard configuration
Doesn't work in all applications because some applications pass an abstract URI instead of the file path in the 'content' scheme
|
||
private fun checkCloakJson(cloakConfigJson: JSONObject): JSONObject { | ||
// todo: strange method | ||
if (!cloakConfigJson.has("NumConn")) cloakConfigJson.put("NumConn", 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PT plugin requires NumConn parameter to be 1. If you have a bigger NumConn parameter then set it to 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the NumConn and ProxyMethod parameters mandatory or optional? Can their values be different? Do I need to check their presence to overwrite them, or can I just always add them to json with the required values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the NumConn and ProxyMethod parameters mandatory or optional?
These are mandatory parameters.
Can their values be different?
For Android OpenVPN over Claok protocol -- no. "NumConn" should always be 1 (without brackets). ProxyMethod -- "openvpn".
Do I need to check their presence to overwrite them, or can I just always add them to json with the required values?
You can just overwrite them in cloak config without checking original values.
These errors are related to VPN connection errors
No description provided.