Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android refactoring #452

Merged
merged 58 commits into from
Dec 23, 2023
Merged

Android refactoring #452

merged 58 commits into from
Dec 23, 2023

Conversation

albexk
Copy link
Collaborator

@albexk albexk commented Dec 4, 2023

No description provided.


private fun checkCloakJson(cloakConfigJson: JSONObject): JSONObject {
// todo: strange method
if (!cloakConfigJson.has("NumConn")) cloakConfigJson.put("NumConn", 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PT plugin requires NumConn parameter to be 1. If you have a bigger NumConn parameter then set it to 1.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the NumConn and ProxyMethod parameters mandatory or optional? Can their values be different? Do I need to check their presence to overwrite them, or can I just always add them to json with the required values?

Copy link
Collaborator

@outspace outspace Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the NumConn and ProxyMethod parameters mandatory or optional?

These are mandatory parameters.

Can their values be different?

For Android OpenVPN over Claok protocol -- no. "NumConn" should always be 1 (without brackets). ProxyMethod -- "openvpn".

Do I need to check their presence to overwrite them, or can I just always add them to json with the required values?

You can just overwrite them in cloak config without checking original values.

@albexk albexk marked this pull request as ready for review December 22, 2023 12:57
@pokamest pokamest merged commit 5ad54bf into dev Dec 23, 2023
5 checks passed
@pokamest pokamest deleted the refactoring/android branch December 23, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants