Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support working without xdg-utils on Linux #2

Closed
joshtriplett opened this issue Jan 11, 2017 · 3 comments
Closed

Please support working without xdg-utils on Linux #2

joshtriplett opened this issue Jan 11, 2017 · 3 comments
Assignees

Comments

@joshtriplett
Copy link

On Linux, opening the default browser uses xdg-open, part of xdg-utils; however, nothing in a default desktop install requires the installation of xdg-utils. Please consider supporting some fallbacks, such as gvfs-open, or parsing the $BROWSER environment variable directly.

@amodm
Copy link
Owner

amodm commented Jan 22, 2017

Thanks for the input @joshtriplett. I'd originally sourced the choice of command on Linux from this stackoverflow discussion.

Will address this as:

  1. Use browser variable if available
  2. Use xdg-open as a fallback

I think using the browser variable should be sufficient instead of adding something like gvfs-open

@amodm amodm self-assigned this Jan 22, 2017
@amodm amodm closed this as completed Jan 22, 2017
@joshtriplett
Copy link
Author

joshtriplett commented Jan 22, 2017

@amodm Thanks for the update. I mostly mentioned gvfs-open because unlike xdg-open, it's installed by default in GNOME environments, and it still respects users' app selections in the GNOME preferences (which don't set $BROWSER). xdg-open is definitely the right tool to start with, but it'd be nice to have fallback commands that are more likely to be installed.

amodm added a commit that referenced this issue Jan 23, 2017
@amodm
Copy link
Owner

amodm commented Jan 23, 2017

@joshtriplett incorporated in v0.2.2 on crates.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants