Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to deal with ETIMEDOUT error and pending forever? #47

Open
fanzijian opened this issue May 5, 2017 · 5 comments
Open

How to deal with ETIMEDOUT error and pending forever? #47

fanzijian opened this issue May 5, 2017 · 5 comments
Assignees

Comments

@fanzijian
Copy link

Hello,
Thanks for the nice robust crawler. But I got ETIMEDOUT error sometimes. Besides, some http request may stay in pending state and the request died after 5 minutes.

Thanks
fanzijian

@tibetty
Copy link
Contributor

tibetty commented Jun 6, 2017

Please refer to my modification over js-crawler from https://github.com/tibetty/ya-js-crawler/blob/master/crawler.js, line#406 & line#450

@amoilanen
Copy link
Owner

Thanks @tibetty We may need to include the modifications from https://github.com/tibetty/ya-js-crawler/blob/master/crawler.js into the default branch of https://github.com/antivanov/js-crawler/ and then we can publish them to NPM. I will take a look

@amoilanen
Copy link
Owner

And thanks to @fanzijian for reporting the issue. Will try to get the fix published soon

@tibetty
Copy link
Contributor

tibetty commented Jun 14, 2017

@antivanov I had customized it too much to fit into my own purpose. I will try to figure out some useful but not so disruptive features and integrate into this project.

@amoilanen
Copy link
Owner

Thanks @tibetty, please create a pull request if there is time and some changes to contribute to the default branch of the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants