Boto now supports Python 3 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about that. If you'd like me to squash the commits into one, just let me know. |
|
Thanks! Sadly It looks like it wasn't tested, on Travis the S3 tests were skipped and once merged they are failing. |
|
Looks like the issue is related to boto/boto#2652 as Boto on Py3 currently doesn't support tempfile instances. |
|
Updated test suite on eeacc9e to rely on NamedTemporaryFile which is correctly supported by Boto in place of TemporaryFile. |
|
Yeah, it looks like Travis omits secure environment variables from tests run for pull requests. I didn't realize that was the case. Glad to see you got it worked out. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.