Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include license and test files in sdist #29

Closed
wants to merge 1 commit into from

Conversation

toddrme2178
Copy link

The MIT license requires license files be included in all copies of the program. The tests are often used by downstream packagers to make sure their builds are correct.

The MIT license requires license files be included in all copies of the program.  The tests are often used by downstream packagers to make sure their builds are correct.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.958% when pulling d8fc72f on toddrme2178:patch-1 into 138b1d9 on amol-:master.

@amol-
Copy link
Owner

amol- commented Aug 30, 2018

I'm not particularly in favour of including non source/data files in source distributions. Especially tests they usually get detected as a package and installed in the site-packages directory, which leads to a tests module that can be imported for no good reason (and that would also override with other packages tests).

Anyone interested in tests can grab the codebase from github and run tests, I see the source distribution more as a form of packaging for install in a Python environment than as a way to actually distribute source code.

@amol- amol- closed this Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants