Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint 2 ready for review #3

Open
amoose20 opened this issue Oct 11, 2022 · 1 comment
Open

Checkpoint 2 ready for review #3

amoose20 opened this issue Oct 11, 2022 · 1 comment

Comments

@amoose20
Copy link
Owner

@pawaitemadisoncollege checkpoint 2 is ready!

@pawaitemadisoncollege
Copy link

pawaitemadisoncollege commented Oct 14, 2022

Hi @amoose20!

Database designed and created

  • Is there an ERD or other document I can review to see the db structure? I'm guessing you may already have a preferred tool to create that, but just in case: the DB View in IntelliJ can be used to generate this if you don't have one.

At least one DAO with full CRUD (create, read, update, delete) implemented with Hibernate & fully unit tested

  • Two daos are implemented with full crud tested - user and team. Good work!

  • Consider more fully testing the relationships between entities - if a user is deleted what happens to their teams? What if a team is deleted? Write test to confirm what should happen does happen. These are also useful as you add more tables and code to make sure existing stuff doesn't break!

  • This is a good time to implement the generic dao. The TeamDao and UserDao can then be removed and the generic dao can be used for any additional tables/entities (I can't remember how may you'll have in the end); tests should just be updated to use the generic dao.

Log4J is implemented (no System.out.printlns)

  • no printlns found :)

Other

  • Time log and journal appear up-to-date
  • Is your project plan up-to-date? Are there additional tasks you can add now that you've learned quite a bit since you wrote the original plan?

Keep up the hard work! Looking forward to seeing some data in the jsps in the next checkpoint!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants