Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing #1

Open
amoraitis opened this issue Oct 23, 2018 · 12 comments
Open

Unit testing #1

amoraitis opened this issue Oct 23, 2018 · 12 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs

Comments

@amoraitis
Copy link
Owner

amoraitis commented Oct 23, 2018

**Is your feature request related to a problem?

We need unit tests to cover the project with.

Currently covered
codecov

@amoraitis amoraitis added help wanted Extra attention is needed good first issue Good for newcomers up-for-grabs labels Oct 23, 2018
@maxalmonte14
Copy link
Contributor

Hi buddy, I like your project, looks very nice indeed 👌

I would like to contribute to it, especially in this particular issue (which is testing coverage).

I have a little question about it, I cloned the project and when I tried to run it, just exploded 😅

I'm using an Ubuntu 16.04 based Linux distribution and I got the following error after logging in:

PlatformNotSupportedException: LocalDB is not supported on this Platform.

Does that mean that the app doesn't run on Linux? The answer looks pretty obvious to me, it would be nice adding Linux support, Thanks to .NET Core should be easy peasy.

@amoraitis
Copy link
Owner Author

@maxalmonte14
Temporary solution: I think that you can use InMemoryDatabase for linux without adding it to Version Control.

I will, also, move to sqlite on the next commit

@maxalmonte14
Copy link
Contributor

Great, I'll try to implement this solution, and then add some tests ✌️

@maxalmonte14
Copy link
Contributor

I'm still on this, I'm having a hard time trying to test async methods, also trying to mock dependencies like DbContext, I have to get use to C# testing tools, but eventually I will make a PR. ✌️

@amoraitis
Copy link
Owner Author

@maxalmonte14 please use docs. Start with this one

@reerden
Copy link
Contributor

reerden commented Oct 1, 2019

I created a PR :) #31

@amoraitis
Copy link
Owner Author

Thank so much for your contribution @remcoe, I will review in the next 1 or 2 days.

@jezmaghuyop
Copy link

Hi, do you still need help with this?

@amoraitis
Copy link
Owner Author

amoraitis commented Oct 16, 2019

@jezmaghuyop This will remain open, we always want better test coverage for the project.

So, feel free to add you tests.

@abc516
Copy link

abc516 commented Oct 15, 2020

Hi @amoraitis , I'm down to add some unit tests too. Any particular areas I could focus on?

@amoraitis
Copy link
Owner Author

Hi @amoraitis , I'm down to add some unit tests too. Any particular areas I could focus on?

Hi, please check for areas not covered yet. I am pretty sure that the TodoItemService is not covered.

@pdelcogliano
Copy link

Hi @amoraitis. Will you please assign this issue to me? I am using #hacktoberfest to get into the OSS community. I think this is a great task for me to work on. BTW, can you also create an issue item to port the code to dot net 7? If you create that issue, you can assign that one to me too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs
Projects
None yet
Development

No branches or pull requests

6 participants