Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests todoItemService #31

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

reerden
Copy link
Contributor

@reerden reerden commented Oct 1, 2019

Issue #1

Added unittests for TodoItemService.AddItemAsync() using Entity Framework Core InMemory database.

@reerden reerden mentioned this pull request Oct 1, 2019
@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #31 into develop will increase coverage by 8.36%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #31      +/-   ##
===========================================
+ Coverage    21.86%   30.23%   +8.36%     
===========================================
  Files           94       87       -7     
  Lines         3457     2550     -907     
===========================================
+ Hits           756      771      +15     
+ Misses        2701     1779     -922
Impacted Files Coverage Δ
TodoList.Web/Data/ApplicationDbContext.cs 70% <40%> (+70%) ⬆️
TodoList.Web/Views/Home/Contact.cshtml 0% <0%> (ø) ⬆️
TodoList.Web/Startup.cs 0% <0%> (ø) ⬆️
...ta/Migrations/ApplicationDbContextModelSnapshot.cs 0% <0%> (ø) ⬆️
TodoList.Web/Views/Shared/_Layout.cshtml 0% <0%> (ø) ⬆️
TodoList.Web/Views/Todos/Home.cshtml 0% <0%> (ø) ⬆️
TodoList.Web/Views/Todos/Index.cshtml 0% <0%> (ø) ⬆️
TodoList.Web/Views/Todos/Create.cshtml 0% <0%> (ø) ⬆️
TodoList.Web/Views/Todos/Details.cshtml 0% <0%> (ø) ⬆️
TodoList.Web/Models/EditViewModel.cs 100% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ad138a...e5354c7. Read the comment docs.

@amoraitis
Copy link
Owner

I am going to keep this PR open. I would like the whole interface in one commit.

Thanks for contributing to the project.

@reerden
Copy link
Contributor Author

reerden commented Oct 3, 2019

I'll try to add some more tests in this PR soon 😃

@amoraitis
Copy link
Owner

@reerden What's the status of this one? Can we please resolve this?

@codecov-commenter
Copy link

Codecov Report

Merging #31 into develop will increase coverage by 1.60%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #31      +/-   ##
===========================================
+ Coverage    28.63%   30.23%   +1.60%     
===========================================
  Files           87       87              
  Lines         2546     2550       +4     
===========================================
+ Hits           729      771      +42     
+ Misses        1817     1779      -38     
Impacted Files Coverage Δ
TodoList.Web/Data/ApplicationDbContext.cs 70.00% <40.00%> (+70.00%) ⬆️
TodoList.Web/Services/TodoItemService.cs 21.05% <0.00%> (+21.05%) ⬆️
TodoList.Web/Models/TodoItem.cs 100.00% <0.00%> (+53.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e73e1...e5354c7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants