Cleanup example modules, extend test coverage.

amos-ws16 · Nov 25, 2016 · c6123de · c6123de
1 parent 5ac1f8e
commit c6123de
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 35 deletions.
diff --git a/lib/fancy-lib.js b/lib/fancy-lib.js
diff --git a/lib/my-module.js b/lib/my-module.js
diff --git a/lib/mylib.js b/lib/mylib.js
diff --git a/test/my-module-test.js b/test/my-module-test.js
diff --git a/test/mylib-test.js b/test/mylib-test.js
diff --git a/test/plugins/close-timestamp-plugin-test.js b/test/plugins/close-timestamp-plugin-test.js
@@ -5,6 +5,11 @@ const timedifferenceLimit = 600
 const uploadTimestamp = 1478886423.003
 
 buster.testCase('Input Scorer', {
+  'should use time limit from param if set': function () {
+    const taskTimestamp = uploadTimestamp - 1234 / 2
+    let result = plugin(uploadTimestamp, taskTimestamp, { 'time-limit': 1234 })
+    buster.assert.equals(result, 0.5)
+  },
   'should return 1.0 when timing matches exactly': function () {
     let result = plugin(uploadTimestamp, uploadTimestamp)
     buster.assert.equals(result, 1.0)

diff --git a/test/score-manager-test.js b/test/score-manager-test.js
@@ -201,6 +201,13 @@ buster.testCase('ScoreManager with configuration', {
 
       let scores = manager.score({ x: {}, y: [0] })
       buster.assert.equals(scores, [{ 'total': 0.8, 'plugin-a': 0.5, 'plugin-b': 0.8 }])
+    },
+
+    'should throw an error if no aggregator by that name exists': function () {
+      this.stubPluginA.returns(0.5)
+      this.stubPluginB.returns(0.8)
+      this.config.aggregator = 'no-aggregator-here'
+      buster.assert.exception(() => scoreManager.create(this.config))
     }
   },