Plugin misconfiguration is not a fatal error.

lib/score-manager.js

@@ -1,4 +1,4 @@
-const VError = require('verror').VError
+// const VError = require('verror').VError
 const extractObject = require('./extract-object')
 const utils = require('./utils')
 const InvalidInputError = require('./invalid-input-error')
@@ -224,22 +224,21 @@ class ScoreManager {
     ensurePluginExists(this.plugins, pluginId)
 
     let plugin = this.plugins[pluginId]
-    let [arg0, arg1] = (() => {
-      try {
-        return plugin.inputs.map(i => extractObject(blob, i))
-      } catch (err) {
-        throw new VError(err, 'Input data does not match configuration')
-      }
-    })()
-    let scoringFnc = getScoringFunction(plugin)
-    let scores = arg1.map(arg1 => {
-      try {
-        return scoringFnc(arg0, arg1, plugin.params)
-      } catch (err) {
-        return 'failure: ' + err.message
-      }
-    })
-    return scores
+    try {
+      // inputs: [arg0, arg1]
+      let [arg0, arg1] = plugin.inputs.map(i => extractObject(blob, i))
+      let scoringFnc = getScoringFunction(plugin)
+      let scores = arg1.map(arg1 => {
+        try {
+          return scoringFnc(arg0, arg1, plugin.params)
+        } catch (err) {
+          return 'failure: ' + err.message
+        }
+      })
+      return scores
+    } catch (err) {
+      return ['failure: input data does not match configuration: ' + err.message]
+    }
   }
 
   /**

test/score-manager-test.js

@@ -71,10 +71,6 @@ buster.testCase('ScoreManager with configuration', {
       buster.assert.exception(() => {
         this.manager.scoreWith('nonexistent-plugin', {})
       })
-    },
-
-    'should rethrow a wrapped error when extractObject throws': function () {
-      buster.assert.exception(() => this.manager.scoreWith('plugin-a', {}))
     }
   },
 
@@ -258,6 +254,28 @@ buster.testCase('ScoreManager with configuration', {
       buster.assert.match(result[0]['plugin-c'], /this is the error description/)
     },
 
+    'should be caught and isolated on a per plugin bases': function () {
+      let aggregator = { combine: this.stub().returns(1.0) }
+      let plugA = () => 1.0
+      let plugB = () => 1.0
+
+      let manager = scoreManager.create({
+        aggregator,
+        plugins: {
+          'plugin-a': { use: plugA, inputs: ['no-attribute-here', 'tasks[]'] },
+          'plugin-b': { use: plugB, inputs: ['file', 'tasks[]'] }
+        }
+      })
+
+      let blob = {
+        file: {},
+        tasks: [{}]
+      }
+
+      let result = manager.score(blob)
+      buster.assert.match(result[0]['plugin-a'], /no-attribute-here/)
+    },
+
     'should only pass successful scores to the aggregator': function () {
       let aggregator = { combine: this.stub() }
       let plugA = () => 1.0