Feature 69 nested aggregators #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
December 2, 2016 15:18
Implement the new concept in ScoreSource and WeightedMean.
Add additional max aggregator.
jhuenges
suggested changes
Dec 11, 2016
| */ | ||
| class Max { | ||
| /** | ||
| * Construct a Max Aggregator using an array of aggregatiors. |
| } else if (!aggregator.combine) { | ||
| throw new InvalidInputError(`Aggregator has no combine function`) | ||
| } | ||
| // if (typeof aggregator === 'string') { |
| function getAggregator (aggregator) { | ||
| return typeof aggregator === 'string' ? new aggregators[aggregator]() : aggregator | ||
| } | ||
| // /** |
| @@ -1,6 +1,7 @@ | |||
| const buster = require('buster') | |||
| const scoreManager = require('../lib/score-manager') | |||
| const aggregator = require('../lib/score-aggregator') | |||
| // const aggregator = require('../lib/score-aggregator') | |||
| buster.testCase('ScoreManager Integration', { | ||
| buster.testCase('ScoreManager Plugin Integration', { | ||
| setUp: function () { | ||
| // this.stubAstEval = this.stub() |
fabian247
reviewed
Dec 11, 2016
| /** | ||
| * Return a WeightedMean Aggregator from an aggregator array. The parameters | ||
| * will be forwarded to WeightedMean.constructor(). | ||
| */ |
There was a problem hiding this comment.
In Z.25 und 26 sollte wohl auch immer Max statt WeightedMead stehen.
fabian247
reviewed
Dec 11, 2016
| @@ -260,7 +262,10 @@ class ScoreManager { | |||
|
|
|||
| let successfulScores = {} | |||
| successfulKeys.forEach(key => { successfulScores[key] = scores[key] }) | |||
| return this.aggregator.combine(successfulScores) | |||
|
|
|||
| let ast = aggregatorConfigParser.parse( | |||
There was a problem hiding this comment.
ast -> aggregatorSourceTree ?
Variable bitte umbenennen für besseres Verständnis
jhuenges
approved these changes
Dec 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.