Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 100 examples documentation #84

Merged
merged 25 commits into from Feb 1, 2017
Merged

Feature 100 examples documentation #84

merged 25 commits into from Feb 1, 2017

Conversation

dn0912
Copy link
Member

@dn0912 dn0912 commented Feb 1, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.76% when pulling 86e7a63 on feature-100-examples-documentation into 5d8e348 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 97.852% when pulling 00b68bf on feature-100-examples-documentation into 5d8e348 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 97.852% when pulling 4d55f94 on feature-100-examples-documentation into 5d8e348 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 100.0% when pulling 9fb12dd on feature-100-examples-documentation into 5d8e348 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 100.0% when pulling b095d91 on feature-100-examples-documentation into 5d8e348 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 100.0% when pulling 4a4ba5b on feature-100-examples-documentation into 5d8e348 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 100.0% when pulling 74f70c0 on feature-100-examples-documentation into 5d8e348 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 100.0% when pulling 3914328 on feature-100-examples-documentation into 5d8e348 on dev.

jhuenges
jhuenges suggested changes Feb 1, 2017
View reviewed changes
Copy link
Contributor

@jhuenges jhuenges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kleinigkeiten :)

docs/examples/plugins/close-time.md Outdated
"idPath": "mappedObjects[].id",
"token": "YOUR_TOKEN_HERE",
"config": {
"idPath": "mappedObjects[].id",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die idPaths sind hier und in den anderen examples nicht immer gleich. Also an der Stelle und was die Einrückung angeht

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gucke ich mir nochmal an

docs/user-guide.md
| trim-left | string | Removes whitespaces on left side (i.e. ' text ' => 'text ') |[Example](examples/pipes/trim-left.md) |
| trim-right | string | Removes whitespaces on right side (i.e. ' text ' => ' text') |[Example](examples/pipes/trim-right.md) |
| basename | string | Removes a dot-extension (i.e. 'file.ext' => 'file') |[Example](examples/pipes/basename.md) |
| day-of-month | timestamp | Extracts the day of the month (1 - 31) | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was ist hier mit den Links?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe die Beispiele hier rausgenommen, weil wir keine Plugins haben, die etwas sinnvolles mit den pipes anfangen können. Daher keine Beispiele

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 100.0% when pulling 6bc4d9f on feature-100-examples-documentation into 5d8e348 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 100.0% when pulling c8e32b4 on feature-100-examples-documentation into 5d8e348 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 100.0% when pulling 01630b3 on feature-100-examples-documentation into 5d8e348 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 100.0% when pulling 9a2548c on feature-100-examples-documentation into 5d8e348 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 100.0% when pulling 9a2548c on feature-100-examples-documentation into 5d8e348 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 100.0% when pulling b004dab on feature-100-examples-documentation into 5d8e348 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 100.0% when pulling b004dab on feature-100-examples-documentation into 5d8e348 on dev.

@simonschwan simonschwan merged commit a49cfb7 into dev Feb 1, 2017
@simonschwan simonschwan deleted the feature-100-examples-documentation branch February 2, 2017 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonschwan simonschwan simonschwan left review comments

@jhuenges jhuenges jhuenges requested changes

Assignees
No one assigned
Labels
1 x Review Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dn0912 @coveralls @jhuenges @simonschwan