-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Up CI pipeline as discussed with Sebastian (IP) #30
Comments
We have two problems with the branch protection:
I think, this means we have to omit the "Main branch protection" acceptance criterion and rely on our team sticking to the rules. |
Hi @Chippelius: Regarding 2.: That shouldn´t be a problem, as students are able to upgrade to Pro for free. That´s the only reason why I am Pro as well :) I would leave it up to you whether you try to get the missing rights or whether you just rely on team-intern rules. If you decide to go for the second one, please communicate it clearly to the rest of the team. |
I now also have GitHub Pro, but sadly, I still cannot setup branch protection rules. |
There are multiple options for creating unit tests in C#. The ones I am aware of, which are the ones suggested by Visual Studio when setting up a unit test project, are: MSTest, NUnit, and xUnit. |
Also, in order to be able to unit-test components that use Xamarin dependencies, a "mocking"-technique is required that lets the component think all of these depencies are there without having to run the whole Xamarin application on actual target platform. |
@NicoStellwag I just saw your standup mail about having implementing unit tests and intending to add more. Since we were tasked with adding unit-tests that work with the CI-Pipeline, we also had to add some. |
Hi Leo,
thanks for the info!
Before implementing we had a look at your branch to make sure we would use
the same testing framework, so we should be fine. 👍
A brief additional info for all developers:
For the mocking of "backend" services we went with Moq (which is the de
facto standard solution for C# as far as I know). We might want to keep
that consistent for the whole code base as well.
See you all on Wednesday! :)
Leo Köberlein ***@***.***> schrieb am So., 15. Mai 2022,
23:52:
… @NicoStellwag <https://github.com/NicoStellwag> I just saw your standup
mail about having implementing unit tests and intending to add more. Since
we were tasked with adding unit-tests that work with the CI-Pipeline, we
also had to add some.
So please check the pull request linked above for compatibility with your
implementation!
—
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANGXC5LHVDH6YKHF66BAATLVKFW2LANCNFSM5VRZM44Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
@Chippelius You can add the dependency right now (so before the team meeting). Just make sure everybody is aware of the change. From our side all fine |
User story
Acceptance criteria
The text was updated successfully, but these errors were encountered: