Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GMLCity Importer #348

Merged
merged 14 commits into from
Jul 3, 2024
Merged

GMLCity Importer #348

merged 14 commits into from
Jul 3, 2024

Conversation

nicolasbandel
Copy link
Contributor

@nicolasbandel nicolasbandel commented Jul 2, 2024 •
edited by Corgam
Loading

Issue #161
Issue #346

@nicolasbandel
file setup
fd385da
@nicolasbandel
WIP started CityGmlImporter (not working yet)
f5e9de7 
Signed-off-by: Nicolas Bandel <nicolas.bandel@fau.de>
@nicolasbandel
Parser is able to read buildings from file
afd1d9c 
Signed-off-by: Nicolas Bandel <nicolas.bandel@fau.de>
@nicolasbandel
working yaml file
c927908 
Signed-off-by: Nicolas Bandel <nicolas.bandel@fau.de>
@nicolasbandel
inserting geometry and xml data into db
35c9a92 
Signed-off-by: Nicolas Bandel <nicolas.bandel@fau.de>
@nicolasbandel
Importer inserts the correct location data
3d7b29f 
Signed-off-by: Nicolas Bandel <nicolas.bandel@fau.de>
@nicolasbandel
Added checks for missing data
71334bf 
Signed-off-by: Nicolas Bandel <nicolas.bandel@fau.de>
@nicolasbandel
extracting groundHeight and insrting into the table
8cb2bff 
Signed-off-by: Nicolas Bandel <nicolas.bandel@fau.de>
@nicolasbandel
extracting districtKey and insrting into the table
00eb454 
Signed-off-by: Nicolas Bandel <nicolas.bandel@fau.de>
@nicolasbandel
extracting check date and insrting into the table
541f79a 
Signed-off-by: Nicolas Bandel <nicolas.bandel@fau.de>
@nicolasbandel
extracting ground area and insrting into the table
c08656f 
Signed-off-by: Nicolas Bandel <nicolas.bandel@fau.de>
@nicolasbandel
formatting
4a49845 
Signed-off-by: Nicolas Bandel <nicolas.bandel@fau.de>
@nicolasbandel nicolasbandel added the backend Issues related to the data, logic, or communication of the application label Jul 2, 2024
@nicolasbandel nicolasbandel self-assigned this Jul 2, 2024
@nicolasbandel
Merge branch 'sprint-release' into Issue#161
a93d7c4 
Signed-off-by: nicolasbandel <131356247+nicolasbandel@users.noreply.github.com>
Corgam
Corgam requested changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@Corgam Corgam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except two things

backend/src/BIE.DataPipeline/DbHelper.cs Outdated Show resolved Hide resolved
backend/src/BIE.DataPipeline/yaml/building_models.yaml Outdated Show resolved Hide resolved
@nicolasbandel
PR fixed
966b069 
Signed-off-by: Nicolas Bandel <nicolas.bandel@fau.de>
@nicolasbandel nicolasbandel requested a review from Corgam July 3, 2024 10:08
Corgam
Corgam approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@Corgam Corgam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing the comments!

@Corgam Corgam merged commit ca44202 into sprint-release Jul 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corgam Corgam Corgam approved these changes

@Superschnizel Superschnizel Awaiting requested review from Superschnizel

@Ahsankkhan Ahsankkhan Awaiting requested review from Ahsankkhan

Assignees

@nicolasbandel nicolasbandel

Labels
backend Issues related to the data, logic, or communication of the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicolasbandel @Corgam