-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use int as scalar type #10
Conversation
been meaning to add the namespace thing as well, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍 some small nitpicks with style and tests need fixing
@@ -81,6 +81,7 @@ const resolveInterfaceName = type => { | |||
|
|||
case 'Float': | |||
case 'Integer': | |||
case 'Int': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you fix the indentation here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additionally, can probably remove the Integer
Type, I think this was just a typo 😢
@@ -5,11 +5,10 @@ const fileIO = require('./fileIO'); | |||
const generateModule = (moduleName, interfaces) => { | |||
return `// graphql typescript definitions | |||
|
|||
declare module ${moduleName} { | |||
declare namespace ${moduleName} { | |||
${interfaces} | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can probably remove this newline as well
No description provided.