Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows style paths #26

Closed
wants to merge 1 commit into from
Closed

Fix windows style paths #26

wants to merge 1 commit into from

Conversation

jordanbtucker
Copy link

  • new method on Connection: normalizePath
  • Ftp- and SftpConnection use normalizePath only when communicating with
    server

Fixes: #22, #18, #17, #8

Justification to put fix in Connection instead of FileManager:

  • FileManager could normalize the paths of the Files it emits, however the paths must still be joined onto the Atom project directory, which will use path.sep anyway.
  • Connection#normalizePath only needs to be called on paths sent to the server; local paths do not need to be normalized.

- new method on Connection: normalizePath
- Ftp- and SftpConnection use normalizePath only when communicating with
server
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) when pulling 56cd148 on jordanbtucker:fix-win-paths into c62107a on amoussard:master.

@amoussard amoussard closed this Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bad path
3 participants