Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Creating the basic structure of the project for Solana buildpacks #5

Merged
merged 11 commits into from
Jan 18, 2024

Conversation

jjeejj
Copy link
Contributor

@jjeejj jjeejj commented Jan 18, 2024

关联 issue #1

@jjeejj jjeejj marked this pull request as ready for review January 18, 2024 03:07
A Cloud Native Buildpack that provides the Solana Tool Suite

## Usage

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forge add command and example?

buildpack.toml Outdated Show resolved Hide resolved
buildpack.toml Outdated Show resolved Hide resolved
buildpack.toml Outdated Show resolved Hide resolved
buildpack.toml Outdated Show resolved Hide resolved
pre-package = "scripts/build.sh"


[[metadata.dependencies]]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? miss config?

func (b Build) Build(context libcnb.BuildContext) (libcnb.BuildResult, error) {
b.Logger.Title(context.Buildpack)
result := libcnb.NewBuildResult()
return result, nil

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return false, fmt.Errorf("unable to determine if Cargo.toml exists\n%w", err)
}
// check src/lib.ts file is exists
_, err = os.Stat(filepath.Join(appDir, "src/lib.rs"))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just check lib.rs?

func (r Solana) Contribute(layer libcnb.Layer) (libcnb.Layer, error) {
r.LayerContributor.Logger = r.Logger
return r.LayerContributor.Contribute(layer, func(artifact *os.File) (libcnb.Layer, error) {
return layer, nil

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangeguo wangeguo merged commit b8871e9 into amp-buildpacks:main Jan 18, 2024
@jjeejj jjeejj deleted the feat/basic-structure branch January 18, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants