Allow each amp instance to override the nginx vhost template #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#21) For example, suppose we've configured the `httpd` as `nginx`: * If the env has variable `NGINX_VHOST_TPL`, use that. * If the web-root or any parent has `.amp/nginx-vhost.php`, use that. * Otherwise, use the default template specified in `amp`.
|
Looking back after two weeks, I have mixed feelings, eg:
|
|
Hey @totten - I am not sure what you mean about blending the dimensions. I thought this was a nice and flexible solution and would vote for a merge. |
|
PS. I am using this branch locally for the moment and it is working for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nginx, each application/instance is likely to need to a different configuration file -- for example, a Drupal template won't work with WordPress or Symfony. To resolve #21, the
amp createcommand must be able to use different templates for different builds.This revision performs a structured search to determine the template, e.g.
* If the env has variable
NGINX_VHOST_TPL, use that.* If the web-root or any parent has
.amp/nginx-vhost.php, use that.* Otherwise, use the default template specified in
amp.The PR is not specific to nginx -- if the
httpdtype is set toapacheorapache24, it will conduct a similar search (e.g.APACHE_VHOST_TPLand.amp/apache-vhost.php; orAPACHE24_VHOST_TPLand.amp/apache24-vhost.php). However, the issue is most salient for nginx.