simplify track regenerate

ampache · Feb 4, 2024 · ab2161f · ab2161f
1 parent 5dd1f72
commit ab2161f
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/Repository/Model/Playlist.php b/src/Repository/Model/Playlist.php
@@ -622,10 +622,12 @@ public function update_track_number($track_id, $index): void
      */
     public function regenerate_track_numbers(): void
     {
-        $items = $this->get_items();
-        $index = 1;
-        foreach ($items as $item) {
-            $this->update_track_number($item['track_id'], $index);
+        $index  = 1;
+        $sql    = 'SELECT `id` FROM `playlist_data` WHERE `playlist_data`.`playlist` = ? ORDER BY `track`, `id`;';
+        $tracks = Dba::read($sql, array($this->id));
+
+        while ($row = Dba::fetch_assoc($tracks)) {
+            $this->update_track_number($row['id'], $index);
             $index++;
         }