Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playcount increments twice when playing via Stream #1739

Closed
sishrad opened this issue Jun 20, 2018 · 3 comments
Closed

playcount increments twice when playing via Stream #1739

sishrad opened this issue Jun 20, 2018 · 3 comments

Comments

@sishrad
Copy link

sishrad commented Jun 20, 2018

Environment

  • Ampache version: 3.8.8
  • Web server + version: Apache/2.4.10
  • Server operating system: Raspbian 8 (jessie)
  • Client operating system: Kubuntu 18.04 LTS (Bionic Beaver)
  • Client type:
    • Web Firefox 60.0.2 (64-bit) sending playlist to Audacious 3.9

Description

When playback is via Stream the playcount is incremented once when generating the playlist (one play for each song in the playlist, clicking "Play" in Firefox) and once more when the song begins in Audacious.

@wagnered
Copy link
Contributor

@sishrad, Sorry I took so long to respond...

I started looking into your issue.

@wagnered
Copy link
Contributor

I tried it with VLC, disabling autostart. No songs had a playcount until I actually started VLC playing them. and songs accrued playcounts only when they were actually played or maybe transferred to the client.

I think it's the way Audacious is handling the playlists/songs. But I couldn't find a way to prevent Audacious from auto starting when receiving a playlist in order to test it.

@lachlan-00
Copy link
Member

This is not longer occurring in develop.
I've also recently added a check to not recount songs immediately after playing. (ie repeating a song before it's finished will not record it twice.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants