Decode scrubbed entities back into user-facing (but sanitized) text #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 93df381 and detected 0 issues on this pull request. View more on Code Climate. |
|
cool, now i'll just need to make sure the search gets the correct data as well. There seems to be some extra stripping/encoding going on on the input part but i'll fix that up. i'll just have to make sure that input isn't being used as a direct input |
i *think* i've got them all but will need to check
|
i've had a quick look and removed the stripping it looks okay but i just need to confirm that all $input is parameterised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps counter-intuitively, we do want to scrub_out $rule[2], then convert any encoded chars back into 'normal' text after it has been sanitized