Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lessen rfc 3514 #3944

Merged
merged 2 commits into from May 6, 2024
Merged

Lessen rfc 3514 #3944

merged 2 commits into from May 6, 2024

Conversation

mitchray
Copy link
Member

@mitchray mitchray commented May 6, 2024

Removes the superfluous use of the evil bit, keeping just one unobtrusive reference in the header.

It was also being used for actual output so those have been renamed.

(sorry to whoever implemented this originally)

@lachlan-00 lachlan-00 merged commit 1faf7db into ampache:patch7 May 6, 2024
2 checks passed
lachlan-00 added a commit that referenced this pull request May 7, 2024
This reverts commit 1faf7db, reversing
changes made to 2cad4bc.
@lachlan-00
Copy link
Member

Seems to break the webplayer popup with this one

@mitchray
Copy link
Member Author

mitchray commented May 7, 2024

Wow, its actually being used for critical operation. I'll revisit this.

Again, wow.

@vollmerk
Copy link
Contributor

vollmerk commented May 7, 2024

Wow, its actually being used for critical operation. I'll revisit this.

Again, wow.

Hahaha, AMAZING - I added that when "AJAX" was just starting to be a thing, and you had to edit the DOM manually. Sad to see it go, but glad that it survived this long in a way.

@mitchray
Copy link
Member Author

mitchray commented May 7, 2024

Its a testament to your efforts (and the web as a whole) that it still works!

New PR here #3945

@lachlan-00
Copy link
Member

Classic Ampache here. (love it)

ajax pages echo xoutput_from_array
image

which defaults to xml
image

(the xoutput request variable only seems to be for next/prev on browses)
image

And then loops back to xoutput_from_array as a callback
image

which seems to be used to avoid putting a header on the string
image

Which is then all echoed out.

at least that makes sense to why the arrays are there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants