Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon key doesn't support data URIs #549

Closed
brandonb927 opened this issue Jan 19, 2017 · 4 comments
Closed

favicon key doesn't support data URIs #549

brandonb927 opened this issue Jan 19, 2017 · 4 comments

Comments

@brandonb927
Copy link

brandonb927 commented Jan 19, 2017

webpack 2.2.0
html-webpack-plugin 2.26.0

I get this error when trying to use a data URI for a blank favicon:

ERROR in   Error: HtmlWebpackPlugin: could not load file /project/path/data:image/x-icon;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQEAYAAABPYyMiAAAABmJLR0T/8JWPfcAAAACXBIWXMAAABIAAAASABGyWs+AAAAF0lEQVRIx2NgGAWjYBSMglEwCkbBSAcACBAAAeaR9cIAAAAASUVORK5CYII=

It looks like the plugin is trying to load the data URI as if it were a local file in the filesystem. I might look into submitting a PR to fix this if nobody picks it up, it's not a deal breaker by any means but a nicety.

@jantimon
Copy link
Owner

jantimon commented Jan 22, 2017

Actually we planed to remove favicon from the HtmlWebpackPlugin because of https://github.com/jantimon/favicons-webpack-plugin
Unfortunately the favicons-webpack-plugin never reached a stable release because of a missing cache feature in webpack itself

@brandonb927
Copy link
Author

Ah ok I will use that plugin instead and close this Issue.

@morewry
Copy link

morewry commented May 1, 2018

For anyone else wanting to do this, check out the linked issue. Apparently the favicon plugin doesn't support this either.

@lock
Copy link

lock bot commented May 31, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants