Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logo key doesn't support data URIs #60

Closed
brandonb927 opened this issue Jan 23, 2017 · 3 comments
Closed

logo key doesn't support data URIs #60

brandonb927 opened this issue Jan 23, 2017 · 3 comments

Comments

@brandonb927
Copy link

brandonb927 commented Jan 23, 2017

webpack 2.2.0
favicons-webpack-plugin 0.0.7

Similar to this issue here, I'm unable to use a data URI for a favicon image. The error below is what is given when trying to do so.

EntryModuleNotFoundError: Entry module not found: Error: Can't resolve 'data:image/x-icon;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQEAYAAABPYyMiAAAABmJLR0T///////8JWPfcAAAACXBIWXMAAABIAAAASABGyWs+AAAAF0lEQVRIx2NgGAWjYBSMglEwCkbBSAcACBAAAeaR9cIAAAAASUVORK5CYII=' in '/fake/project/path'

@brandonb927 brandonb927 changed the title favicon key doesn't support data URIs logo key doesn't support data URIs Jan 23, 2017
@jantimon
Copy link
Owner

This would be possible however webpack itself doesn't support base64 images for loaders which would cause a lot of work arounds.

@brandonb927
Copy link
Author

Thanks for the feedback! I'm not too familiar with how webpack works underneath the hood but this seems like an oversight no? Regardless, I might just use a blank PNG then for this if it's not going to be supported.

Cheers

@morewry
Copy link

morewry commented May 1, 2018

What do loaders have to do with this? If I want to use a base64 encoded image as a data URI, it doesn't need to run through a loader. It's supported in the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants