Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create parent dirs to JUnit report file if needed #54

Merged
merged 2 commits into from May 24, 2021

Conversation

aengelberg
Copy link
Contributor

To make the JUnit reporting feature more easily useable in CI workflows, I propose automatically creating parent directories of the JUnit report file if needed. This allows CircleCI config like the following:

- run: lein run -m my.main.greenlight.ns --junit-report build/junit.xml
- store_test_results:
    path: build

This change also makes Greenlight's JUnit reporter more consistent with other JUnit reporters like kaocha and test2junit.

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021

Codecov Report

Merging #54 (d49ea45) into master (b06c59c) will increase coverage by 0.96%.
The diff coverage is 100.00%.

❗ Current head d49ea45 differs from pull request most recent head 65220b1. Consider uploading reports for the commit 65220b1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   66.26%   67.23%   +0.96%     
==========================================
  Files           6        6              
  Lines         584      586       +2     
  Branches       39       38       -1     
==========================================
+ Hits          387      394       +7     
+ Misses        158      154       -4     
+ Partials       39       38       -1     
Impacted Files Coverage Δ
src/greenlight/report.clj 78.43% <100.00%> (+1.43%) ⬆️
src/greenlight/runner.clj 40.11% <0.00%> (+1.69%) ⬆️
src/greenlight/report/junit.clj 97.05% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b06c59c...65220b1. Read the comment docs.

@greglook greglook requested a review from a team May 20, 2021 16:24
@greglook greglook added the enhancement New feature or request label May 20, 2021
Copy link
Contributor

@greglook greglook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice quality-of-life improvement. 🙆‍♂️

src/greenlight/report.clj Outdated Show resolved Hide resolved
Co-authored-by: Greg Look <greg@greg-look.net>
@drewinglis
Copy link
Contributor

Looks like we need to update cljstyle.

@drewinglis drewinglis merged commit 44f69cb into amperity:master May 24, 2021
drewinglis added a commit that referenced this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants