Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies in profiles aren't included in dependency calculations #51

Closed
drewinglis opened this issue Oct 21, 2019 · 1 comment · Fixed by #52
Closed

Dependencies in profiles aren't included in dependency calculations #51

drewinglis opened this issue Oct 21, 2019 · 1 comment · Fixed by #52
Assignees

Comments

@drewinglis
Copy link
Contributor

drewinglis commented Oct 21, 2019

If you have a project with a profile dependency on another project:

(defproject project-b "MONOLITH-SNAPSHOT"
  ,,,
  :profiles {:test {:dependencies [project-a "MONOLITH-SNAPSHOT"]}})

lein monolith each with-profile +test do clean, deps, install will allow project-b to run before project-a, which can cause the build to fail. We should include profile information with the dependency calculation.

@aengelberg
Copy link
Contributor

aengelberg commented Oct 21, 2019

Could lein-monolith optimistically consider all of each project's profiles as part of reality for the purpose of computing the topological order of projects? This would avoid needing to infer what a given each command is going to try to do, and probably add more predictability in general. (Or maybe this is precisely what you are suggesting.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants