Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update union implementation for Spark 2/3 cross-compatibility #21

Merged
merged 2 commits into from Aug 5, 2021

Conversation

brandonvin
Copy link
Contributor

@brandonvin brandonvin commented Aug 4, 2021

Spark 3 removed the signatures of JavaSparkContext#union that sparkplug was using, leaving only the varargs signatures: https://issues.apache.org/jira/browse/SPARK-25737

This modifies the implementation of sparkplug.core/union to use the varargs signature so that it works with both Spark 2 and Spark 3.

Copy link
Collaborator

@greglook greglook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆‍♂️

Copy link
Member

@jstokes jstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brandonvin brandonvin merged commit c2fd192 into master Aug 5, 2021
@brandonvin brandonvin deleted the union-spark-3-compat branch August 5, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants