Fix serialized record closures #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug surfaces when Sparkplug tries to serialize functions which are closures defined inside of a
defrecordform. The resulting serialized value includes a reference to the record name itself as a "namespace" to require before the function is loaded, but this fails on the executor because records aren't namespaces. This wasn't being caught by the existing(class? (resolve x))check, because in this case the record was in a namespace that had hyphens in it, and class names must use the underscore version (thanks Java).To fix this, we need to make the logic here a bit more robust - now it correctly detects class names by swapping out the underscores, and if the parent of that class is itself a namespace, use that instead. The existing behavior should continue ignoring values like
clojure.lang.Keyword.