Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some write endpoints return crucial data, but vault write-secret! throws it away #17

Closed
kenrestivo-stem opened this issue Dec 21, 2017 · 0 comments
Labels

Comments

@kenrestivo-stem
Copy link
Contributor

write-secret returns only a boolean if the status code is 204.

Some endpoints, such as PKI write-secret, return 200 error codes with vital information (like private keys) that can't be obtained any other way.

(vault/write-secret! @v/client "pki_int/issue/foo-dot-com" {"common_name" "foo.com"})

Returns false.

Correct return value in this case would be the :body of the response.

kenrestivo-stem added a commit to kenrestivo-stem/vault-clj that referenced this issue Dec 21, 2017
kenrestivo-stem added a commit to kenrestivo-stem/vault-clj that referenced this issue Dec 21, 2017
kenrestivo-stem added a commit to kenrestivo-stem/vault-clj that referenced this issue Dec 21, 2017
@greglook greglook added the bug label Dec 22, 2017
kenrestivo-stem added a commit to kenrestivo-stem/vault-clj that referenced this issue Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants