Add LDAP support #14 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #16 +/- ##
==========================================
- Coverage 25.24% 24.95% -0.3%
==========================================
Files 6 6
Lines 511 521 +10
Branches 15 15
==========================================
+ Hits 129 130 +1
- Misses 367 376 +9
Partials 15 15
Continue to review full report at Codecov.
|
greglook
reviewed
Sep 11, 2017
src/vault/client/http.clj
Outdated
| [client credentials] | ||
| (let [{:keys [username password]} credentials] | ||
| (api-auth! | ||
| (str "user " username) |
There was a problem hiding this comment.
The string here should be "ldap " to distinguish this from the username/password auth method.
As requested
greglook
approved these changes
Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add LDAP auth support.
Tested here, appears to work.