Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds force renew parameter to read-secret #22

Merged
merged 2 commits into from Mar 20, 2018

Conversation

aclev
Copy link
Member

@aclev aclev commented Mar 15, 2018

No description provided.

@aclev aclev requested a review from greglook March 15, 2018 21:03
@codecov-io
Copy link

codecov-io commented Mar 15, 2018

Codecov Report

Merging #22 into develop will increase coverage by 0.13%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #22      +/-   ##
===========================================
+ Coverage    26.69%   26.82%   +0.13%     
===========================================
  Files            6        6              
  Lines          532      533       +1     
  Branches        15       15              
===========================================
+ Hits           142      143       +1     
  Misses         375      375              
  Partials        15       15
Impacted Files Coverage Δ
src/vault/core.clj 75% <ø> (ø) ⬆️
src/vault/client/http.clj 16.37% <50%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92140b6...0def7f4. Read the comment docs.

cannot be renewed.")
cannot be renewed.
- `:force-renew`
Whether or not to force renew this secret regardless of lease expiry.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be slightly clearer I think - the fact that the option ends in -renew makes it seem related to the :renew option, but that causes action in the future while this causes action now. In hindsight, I kind of wish I'd named these :auto-renew and :auto-rotate.

How about:

Force the secret to be read from the server even if there is a valid lease cached.

A better name might be :force-read?

@greglook greglook self-assigned this Mar 20, 2018
@greglook greglook merged commit 7270c15 into amperity:develop Mar 20, 2018
@greglook
Copy link
Collaborator

Released in 0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants