Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renewing the client token should update the internal auth state #26

Merged
merged 1 commit into from Oct 11, 2018

Conversation

greglook
Copy link
Collaborator

@greglook greglook commented Oct 5, 2018

This fixes the log/vault spam issue with periodic tokens and app-role services.

@greglook greglook requested a review from pyncc October 5, 2018 22:09
@codecov-io
Copy link

Codecov Report

Merging #26 into develop will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #26      +/-   ##
===========================================
- Coverage    27.46%   27.17%   -0.29%     
===========================================
  Files            6        6              
  Lines          579      585       +6     
  Branches        17       17              
===========================================
  Hits           159      159              
- Misses         403      409       +6     
  Partials        17       17
Impacted Files Coverage Δ
src/vault/core.clj 75% <ø> (ø) ⬆️
src/vault/client/http.clj 19.4% <0%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 586a347...666916f. Read the comment docs.

Copy link
Contributor

@pyncc pyncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@pyncc pyncc merged commit 7c74e2a into develop Oct 11, 2018
@pyncc pyncc deleted the fix-token-renewal branch October 11, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants