Support aws IAM authentication #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexparlett
force-pushed
the
master
branch
2 times, most recently
from
80914c7
to
9f79fe0
Compare
greglook
requested changes
Mar 25, 2021
greglook
approved these changes
Mar 31, 2021
pyncc
approved these changes
Mar 31, 2021
Co-authored-by: Greg Look <greg@greg-look.net>
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 53.82% 55.44% +1.61%
==========================================
Files 10 10
Lines 654 680 +26
Branches 28 29 +1
==========================================
+ Hits 352 377 +25
Misses 274 274
- Partials 28 29 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To sanity check on this vault does expect the iam payload values to be b64 encoded, at the moment I have left that to the consumer to understand as I didn't want to pull additional dependencies into the project. Let me know if you think that is worth changing.