Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use log/infof for log message in vault.authenticate namespace #51

Merged
merged 1 commit into from Apr 26, 2021
Merged

Use log/infof for log message in vault.authenticate namespace #51

merged 1 commit into from Apr 26, 2021

Conversation

brandonvin
Copy link
Contributor

This was mistakenly using log/info and logging a raw format string.

@brandonvin brandonvin requested a review from Geeber April 26, 2021 21:07
@brandonvin brandonvin requested a review from pyncc as a code owner April 26, 2021 21:07
pyncc
pyncc approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@pyncc pyncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@pyncc pyncc merged commit 20d16f6 into master Apr 26, 2021
@pyncc pyncc deleted the vault-authentication-log-infof branch April 26, 2021 21:09
@pyncc
Copy link
Contributor

pyncc commented Apr 27, 2021

https://github.com/amperity/vault-clj/releases/tag/1.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyncc pyncc pyncc approved these changes

@Geeber Geeber Awaiting requested review from Geeber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandonvin @pyncc