Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic integration tests #57

Merged
merged 14 commits into from Aug 19, 2021
Merged

Basic integration tests #57

merged 14 commits into from Aug 19, 2021

Conversation

greglook
Copy link
Collaborator

Follow up to the previous breaking changes, this PR adds a set of basic integration tests for the kv secrets engines. This makes use of Vault's development server mode, which runs locally and in-memory.

@greglook greglook requested review from pyncc and a team August 17, 2021 19:03
Copy link
Contributor

@pyncc pyncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, just one thing to fix so the CI tests pass I think.

test/vault/integration.clj Show resolved Hide resolved
@greglook greglook requested a review from pyncc August 19, 2021 16:49
Copy link
Contributor

@pyncc pyncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo this is great thank you!!

@pyncc pyncc merged commit 9adbd7c into master Aug 19, 2021
@pyncc pyncc deleted the basic-integration-tests branch August 19, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants