Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trigger happy on exclamation mark warnings #322

Closed
puterleat opened this issue Mar 7, 2016 · 0 comments
Closed

trigger happy on exclamation mark warnings #322

puterleat opened this issue Mar 7, 2016 · 0 comments

Comments

@puterleat
Copy link

When processing markdown or Rmd files it's quite common to have html comments like

<!--- stuff here --->

Which presently get counted towards this warning: "More than 30 ppm of exclamations. Keep them under control." Perhaps exclamations within comments should be excluded?
@mpacer mpacer added bug labels Mar 7, 2016
suchow pushed a commit that referenced this issue Mar 8, 2016
@jsenn @suchow
Only complain about punctuational exclamation marks. Fixes #322
2db5fd9
@suchow suchow closed this as completed in 3ca7ac3 Mar 8, 2016
suchow added a commit that referenced this issue Mar 8, 2016
@suchow
Merge pull request #339 from jsenn/fix-exclam
1d2fd6c 
Complain about punctuational exclamation marks only. Fixes #322
@jayvdb jayvdb mentioned this issue Nov 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@puterleat @mpacer