Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct false positives for lexical illusion regex #1192

Merged
merged 2 commits into from Jul 6, 2021

Conversation

suchow
Copy link
Member

@suchow suchow commented Jul 6, 2021

Hotfix for #1191

@suchow suchow requested a review from Nytelife26 as a code owner July 6, 2021 02:24
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #1192 (c44733a) into main (1ee5a34) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1192   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files          83       83           
  Lines        1213     1213           
=======================================
  Hits         1149     1149           
  Misses         64       64           
Flag Coverage Δ
macos-latest 94.72% <100.00%> (ø)
py3.6 94.20% <100.00%> (ø)
py3.7 94.20% <100.00%> (ø)
py3.8 94.72% <100.00%> (ø)
py3.9 94.72% <100.00%> (ø)
pypypy3 94.20% <100.00%> (ø)
ubuntu-latest 94.72% <100.00%> (ø)
windows-latest 94.72% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
proselint/checks/lexical_illusions/misc.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee5a34...c44733a. Read the comment docs.

@suchow
Copy link
Member Author

suchow commented Jul 6, 2021

Screen Shot 2021-07-05 at 10 22 25 PM

Screen Shot 2021-07-05 at 10 22 32 PM

@suchow suchow requested review from Nytelife26 and removed request for Nytelife26 July 6, 2021 02:25
@suchow
Copy link
Member Author

suchow commented Jul 6, 2021

@Nytelife26 If this looks okay to you, let's cut a release asap.

@Nytelife26 Nytelife26 added bug: fixed-in-next Bugs present in the current release but fixed on the main branch. cat: false-positive Issues and PRs related to false positives in proselint rules. priority: urgent Issues and PRs that must be resolved immediately. status: merge-ready PRs that are ready to merge. type: fix Issues and PRs related to bugs. version: patch Issues and PRs with bug fixes belonging to the next patch release. labels Jul 6, 2021
@Nytelife26 Nytelife26 changed the title Fix lexical illusion regex fix: correct false positives for lexical illusion regex Jul 6, 2021
@Nytelife26 Nytelife26 merged commit 7de5faa into main Jul 6, 2021
@Nytelife26 Nytelife26 deleted the lexical-illusion-hotfix branch July 6, 2021 07:49
@Nytelife26 Nytelife26 added bug: fixed Bugs that have been fixed. and removed bug: fixed-in-next Bugs present in the current release but fixed on the main branch. labels Jul 6, 2021
@Nytelife26 Nytelife26 linked an issue Jul 6, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: fixed Bugs that have been fixed. cat: false-positive Issues and PRs related to false positives in proselint rules. priority: urgent Issues and PRs that must be resolved immediately. status: merge-ready PRs that are ready to merge. type: fix Issues and PRs related to bugs. version: patch Issues and PRs with bug fixes belonging to the next patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False alarm on lexical illusions
2 participants