Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use absolute import to find proselint.tools #328

Merged
merged 1 commit into from Mar 8, 2016

Conversation

jstewmon
Copy link

@jstewmon jstewmon commented Mar 8, 2016

fixes #304

@mpacer
Copy link
Member

mpacer commented Mar 8, 2016

It looks like I have to make a new branch to get it to merge other changes with our protected master branch, apologies if this in any way obscures your contributions, though I think it should still recognize them.

mpacer pushed a commit that referenced this pull request Mar 8, 2016
use absolute import to find proselint.tools
@mpacer mpacer merged commit 3be968a into amperser:master Mar 8, 2016
@mpacer
Copy link
Member

mpacer commented Mar 8, 2016

AH, nvm @suchow figured it out. Figured it was good to document it here for myself and others…

To able to rebase a pr against a master branch you don't need the requester to make any changes to their end, you have control over the pr by using a command like:

git push --set-upstream origin pr/#

where # is replaced by the pr number (in this case 328)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proselint --initialize throws errors
2 participants